Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[l10n] Improve German (de-DE) locale #3230

Merged
merged 2 commits into from
Nov 21, 2021
Merged

[l10n] Improve German (de-DE) locale #3230

merged 2 commits into from
Nov 21, 2021

Conversation

sebastianfrey
Copy link
Contributor

This PR adds the missing translation for the deDE locale requested in #3211. In addition, I have sharpened the translation for filterOperatorOnOrAfter and filterOperatorOnOrBefore so that it is grammatically correct.

@oliviertassinari oliviertassinari changed the title [DataGrid] Add missing translation for deDE locale [l10n] Add missing translation for deDE locale Nov 21, 2021
@oliviertassinari oliviertassinari changed the title [l10n] Add missing translation for deDE locale [l10n] Add missing translation for de_DE locale Nov 21, 2021
@oliviertassinari oliviertassinari added the l10n localization label Nov 21, 2021
@oliviertassinari oliviertassinari merged commit b3aa73c into mui:master Nov 21, 2021
@oliviertassinari
Copy link
Member

@sebastianfrey Great, thanks for the help

@m4theushw
Copy link
Member

@sebastianfrey Thanks for your help. After syncing with the English locale, I noticed that there're still a couple of translations missing. I've updated #3211. If you want to do a follow-up PR we're gonna love.

https://github.com/mui-org/material-ui-x/blob/d826fc758ee01cb2a599042f7d19cfc173a123a9/packages/grid/_modules_/grid/locales/deDE.ts#L34
https://github.com/mui-org/material-ui-x/blob/d826fc758ee01cb2a599042f7d19cfc173a123a9/packages/grid/_modules_/grid/locales/deDE.ts#L68
https://github.com/mui-org/material-ui-x/blob/d826fc758ee01cb2a599042f7d19cfc173a123a9/packages/grid/_modules_/grid/locales/deDE.ts#L69
https://github.com/mui-org/material-ui-x/blob/d826fc758ee01cb2a599042f7d19cfc173a123a9/packages/grid/_modules_/grid/locales/deDE.ts#L70
https://github.com/mui-org/material-ui-x/blob/d826fc758ee01cb2a599042f7d19cfc173a123a9/packages/grid/_modules_/grid/locales/deDE.ts#L101
https://github.com/mui-org/material-ui-x/blob/d826fc758ee01cb2a599042f7d19cfc173a123a9/packages/grid/_modules_/grid/locales/deDE.ts#L104
https://github.com/mui-org/material-ui-x/blob/d826fc758ee01cb2a599042f7d19cfc173a123a9/packages/grid/_modules_/grid/locales/deDE.ts#L105

@sebastianfrey sebastianfrey mentioned this pull request Nov 23, 2021
Merged
@oliviertassinari oliviertassinari changed the title [l10n] Add missing translation for de_DE locale [l10n] Improve German (de_DE) locale Nov 28, 2021
@oliviertassinari oliviertassinari added the component: data grid This is the name of the generic UI component, not the React module! label Nov 28, 2021
@oliviertassinari oliviertassinari changed the title [l10n] Improve German (de_DE) locale [l10n] Improve German (de-DE) locale Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! l10n localization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebastianfrey @oliviertassinari @m4theushw